Page 1 of 1

[FIX] falling maple leaves crash

PostPosted: Sat Sep 29, 2012 11:13 pm
by Chiprel
Some players crash after being 1-3mins near falling maple leaves.
This file removes falling leaves animation:
https://dl.dropbox.com/u/95535397/gfx.zip

1. Unzip it and:
-On Ender client put it in: yourUSER/salem/custom_res/
-On BDSaleM client put it in: your_BDSalem_client_folder/res/

2. Paste it so it looks like this:
salem/custom_res/gfx/terobjs/...etc
your_BDSalem_client_folder/res/gfx/terobjs/...etc

3. Have fun playing without crashes :D

edit: some posts about this issue:
- http://forum.paradoxplaza.com/forum/sho ... m-need-dev (thanks to staxjax for finding it on old forums)
- http://forum.salemgame.com/viewtopic.ph ... aves#p3254
- http://forum.salemgame.com/viewtopic.ph ... aves#p5085

Re: [FIX] falling maple leaves crash

PostPosted: Sat Sep 29, 2012 11:20 pm
by Ornery
Very cool, I know some people who couldn't really play because of this. Thanks, hopefully it works for them, too.

Re: [FIX] falling maple leaves crash

PostPosted: Sat Sep 29, 2012 11:22 pm
by staxjax
If you are having this problem, your error report will look like this:


javax.media.opengl.GLException: haven.GOut$GLException: GL Error: 1281 (invalid value)
at javax.media.opengl.Threading.invokeOnOpenGLThread( Threading.java:271)
at javax.media.opengl.GLCanvas.maybeDoSingleThreadedW orkaround(GLCanvas.java:410)
at javax.media.opengl.GLCanvas.display(GLCanvas.java: 244)
at haven.HavenPanel.uglyjoglhack(HavenPanel.java:380)
at haven.HavenPanel.run(HavenPanel.java:414)
at java.lang.Thread.run(Unknown Source)
Caused by: haven.GOut$GLException: GL Error: 1281 (invalid value)
at haven.GOut.checkerr(GOut.java:84)
at haven.GLState$Applier.apply(GLState.java:470)
at haven.GOut.apply(GOut.java:160)
at haven.res.lib.leaves.FallingLeaves$MSlot.draw(Fall ingLeaves.java:36)
at haven.RenderList.render(RenderList.java:207)
at haven.RenderList.render(RenderList.java:218)
at haven.PView.draw(PView.java:155)
at haven.MapView.draw(MapView.java:707)
at haven.Widget.draw(Widget.java:426)
at haven.Widget.draw(Widget.java:431)
at haven.GameUI.draw(GameUI.java:293)
at haven.Widget.draw(Widget.java:426)
at haven.Widget.draw(Widget.java:431)
at haven.RootWidget.draw(RootWidget.java:73)
at haven.UI.draw(UI.java:141)
at haven.HavenPanel.redraw(HavenPanel.java:268)
at haven.HavenPanel$1.display(HavenPanel.java:88)
at com.sun.opengl.impl.GLDrawableHelper.display(GLDra wableHelper.java:78)
at javax.media.opengl.GLCanvas$DisplayAction.run(GLCa nvas.java:435)
at com.sun.opengl.impl.GLDrawableHelper.invokeGL(GLDr awableHelper.java:194)
at javax.media.opengl.GLCanvas$DisplayOnEventDispatch ThreadAction.run(GLCanvas.java:452)
at java.awt.event.InvocationEvent.dispatch(Unknown Source)
at java.awt.EventQueue.dispatchEventImpl(Unknown Source)
at java.awt.EventQueue.access$000(Unknown Source)
at java.awt.EventQueue$1.run(Unknown Source)
at java.awt.EventQueue$1.run(Unknown Source)
at java.security.AccessController.doPrivileged(Native Method)
at java.security.AccessControlContext$1.doIntersectio nPrivilege(Unknown Source)
at java.awt.EventQueue.dispatchEvent(Unknown Source)
at java.awt.EventDispatchThread.pumpOneEventForFilter s(Unknown Source)
at java.awt.EventDispatchThread.pumpEventsForFilter(U nknown Source)
at java.awt.EventDispatchThread.pumpEventsForHierarch y(Unknown Source)
at java.awt.EventDispatchThread.pumpEvents(Unknown Source)
at java.awt.EventDispatchThread.pumpEvents(Unknown Source)
at java.awt.EventDispatchThread.run(Unknown Source)

Re: [FIX] falling maple leaves crash

PostPosted: Sat Sep 29, 2012 11:42 pm
by loftar
Does this actually entirely fix the bug, however? From staxjax' backtrace it is clear that the bug does not happen in the animation itself, since it crashes in GLState.Applier.apply() which is called before the leaves are actually drawn (and could, therefore, simply un-apply some previous state which is actually what causes the error; or the error could, for that matter, have occurred entirely before anything which even touches the leaves, and is simply not detected until apply() checks for latent GL errors), and the leaves don't actually use any special state that would make them differ from any other object in the actually apply() call. I'm not saying that the bug cannot be related to the leaves, but if it is, then I'm just not seeing how it would be related.

Please verify, therefore, whether this fix makes the problem disappear entirely.

Re: [FIX] falling maple leaves crash

PostPosted: Sat Sep 29, 2012 11:50 pm
by Ass_Kraken
I can confirm it works. Thanks troj.

Re: [FIX] falling maple leaves crash

PostPosted: Tue Nov 13, 2012 5:15 am
by Eman
Uhm, I have that error but I have no idea what to do with that file. I am not using the Ender or BD clients. I tried to find some sort of Salem folder but I can't find any. Can you please explain in detail what to do with the file? Greatly appreciated.

Re: [FIX] falling maple leaves crash

PostPosted: Thu Nov 15, 2012 1:39 pm
by Chiprel
Didn't test it but it should work on default client if you do this:
put trunk.res(from gfx.zip file in first post) into:
yourUSER\.salem\cache\res\gfx\terobjs\tree\maple\
then delete trunk.cached and rename trunk.res to trunk.cached

Re: [FIX] falling maple leaves crash

PostPosted: Fri Nov 16, 2012 11:19 pm
by loftar
I think I have fixed the root problem now. I don't actually know, though, since I don't have any system on which the error has occurred to begin with, so it would be nice if someone could verify it.

Re: [FIX] falling maple leaves crash

PostPosted: Wed Nov 21, 2012 4:53 pm
by Ass_Kraken
I don't believe it is fixed. I have been having trouble staying logged in since the multi-server update and get this error

http://pastebin.com/gDjXvBcT

It seems to be the same error stax posted, but I have tested it with trojanz' fix put on the client, and off the client and it dosen't work. I've tried on every client, vanilla, ender's, BDSaleM.

Strangely enough I get it at my place that is entirely void of trees in like 30 seconds, about the same on alts in the wild, but in boston I can stay logged in for like 10 minutes before it crashes.

Re: [FIX] falling maple leaves crash

PostPosted: Wed Nov 21, 2012 6:06 pm
by loftar
Ass_Kraken wrote:Strangely enough I get it at my place that is entirely void of trees in like 30 seconds, about the same on alts in the wild, but in boston I can stay logged in for like 10 minutes before it crashes.

In that case, I think that is at least a rather good indication that the error isn't actually related to the maple leaves, but to something else.